Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add account metrics resource #94

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add account metrics resource #94

wants to merge 10 commits into from

Conversation

ennyjfrick
Copy link
Contributor

What was changed

Hi again! This PR adds a new resource to configure account-level metrics. It allows enabling and disabling of an account's metrics endpoint, configuring the CA cert accepted by the metrics endpoint, and exporting the metrics endpoint URI once created.

Why?

The new resource is intended to enable a better experience for operators with certificate and observability infrastructure already in Terraform. Instead of needing to configure certificates and Prometheus scrapes for Temporal Cloud out-of-band, Temporal Cloud observability features can now slot nicely in with existing Terraform configuration.

Checklist

  1. How was this tested:
    Run acceptance tests

  2. Any docs updates needed?
    Docs generated!

@ennyjfrick ennyjfrick requested a review from a team as a code owner April 24, 2024 17:08
@swgillespie
Copy link
Collaborator

thank you for all of the hard work on these 🙏 I will check this out!

@anekkanti
Copy link
Member

@ennyjfrick thank you for your PR.

The protos/apis you are referring from the tcld repo are meant to be deprecated, and will be replaced by the once in api-cloud repo.
We have a proposed account metrics mgmt apis that we are working on. PR:temporalio/api-cloud#14. We hope to get this out soon.
Can we hold off on this PR and wait for the apis to be available?

@ennyjfrick
Copy link
Contributor Author

@anekkanti totally fine with me!

@ennyjfrick
Copy link
Contributor Author

@anekkanti hey! wondering if there was any update on the updated account management APIs

@swgillespie
Copy link
Collaborator

@anekkanti can you share any updates you have here?

@ennyjfrick ennyjfrick mentioned this pull request Aug 14, 2024
Open
@anekkanti
Copy link
Member

anekkanti commented Aug 21, 2024 •
edited
Loading

@ennyjfrick @swgillespie
We finally have a path to unblock the above APIs, and i am working on it.
It will likely take us at least a few weeks to get the required APIs out for metrics mgmt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ennyjfrick @swgillespie @anekkanti